![]() Please wait while updating issue type...
Could not save your changes
This issue has been changed since you started editing it
Data that has been changed is highlighted in red below. Undo your changes to see the updated information
You have changed this issue, but haven't saved your changes yet. To save it, press the Save changes button to the right
This issue is blocking the next release
![]() There are no comments
There is nothing attached to this issue
This issue has no duplicates
There are no code checkins for this issue |
|||||||||||||||||||||||||||||||||||
Really delete this comment?
Really delete this comment?
https://github.com/subes/invesdwin-context-integration/blob/master/invesdwin-context-integration-parent/invesdwin-context-integration-jppf/src/main/java/de/invesdwin/integration/jppf/client/ConfiguredClientDriverDiscovery.java
Specifically:
Really delete this comment?
Furthermore, while reviewing the code of this method, I realized it is completely wrong. The condition if (!props.contains(name)) should be if (!props.containsKey(name)). Also a null check on the result of getProperty(name) is indeed missing.
Really delete this comment?
Really delete this comment?
Really delete this comment?
However, the NPE does not occur systematically, but around twice out of 3 times. The idea is to be removing properties from System.getProperties() while in parallel SystemUtils.addOtherSystemProperties() is iterating over the system properties. This is the only way System.getProperty(String) can return null, since, according to the Javadoc for Hashtable, null keys or values are not supported:
Really delete this comment?
Really delete this comment?